Enforce discard limits on readers#790
Open
emcfarlane wants to merge 2 commits into
Open
Conversation
This enforces limits on discard to avoid unbounded reads. Where resources were already exhausted no further reads are done and discards have been removed. These discards were an optimization to reuse connections. When a stream is partially read all subsequent reads will now return EOF errors to avoid reading in a corrupted state. Signed-off-by: Edward McFarlane <emcfarlane@buf.build>
emcfarlane
force-pushed
the
ed/limitDiscards
branch
from
73a761b to
a933acd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enforces limits on discard to avoid unbounded reads. Where resources were already exhausted no further reads are done and discards have been removed. These discards were an optimization to reuse connections. When a stream is partially read all subsequent reads will now return EOF errors to avoid reading in a corrupted state.
Fixes #620